[ang-1018] Fix removing contributors #11360
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Misc fixes for Angular migration.
Misc fixes for angular migration
Misc. fixes for Angular migration
Misc. fixes for Angular migration
Misc. fixes for Angular Migration
Misc. fixes for Angular migration
Misc. fixes for Anuglar migration
adlius
added a commit
that referenced
this pull request
Oct 13, 2025
) (#11363) Co-authored-by: Oleh Paduchak <158075011+opaduchak@users.noreply.github.com> Co-authored-by: Longze Chen <cslzchen@gmail.com>
|
This is a very strange PR. Is there really no url that would take users to a "login page" that upon logging in would redirect to the addons page? At the very least, it'd be considerably more accessible to have the earlier text link to the login page... |
Contributor
Author
|
Thanks for your comment — I appreciate your input. I completely understand your concerns. We’ve recently migrated to an Angular frontend, so we no longer use server‑side rendering (except in rare cases). I fully agree that having a link to the login page improves the user experience, but that logic now needs to be handled on the frontend rather than the backend. Cheers, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Changes
QA Notes
Please make verification statements inspired by your code and what your code touches.
What are the areas of risk?
Any concerns/considerations/questions that development raised?
Documentation
Side Effects
Ticket