Skip to content

Conversation

@aaxelb
Copy link
Contributor

@aaxelb aaxelb commented Oct 15, 2025

Purpose

clean up after the last institution dashboard project, now that the dust has settled and its feature flag is permanently on

Changes

  • remove feature flag INSTITUTIONAL_DASHBOARD_2024 and all code deadened by it
    • delete "old" views and serializers for institution summary and institution user
    • rename corresponding "new" views and serializers to remove "new"
    • delete osf.metrics.InstitutionProjectCounts (replaced by osf.metrics.reports.InstitutionMonthlySummaryReport)
    • delete osf.metrics.UserInstitutionProjectCounts (replaced by osf.metrics.reports.InstitutionalUserReport)
  • update institution-departments view to get department names and counts from InstitutionalUserReport (instead of UserInstitutionProjectCounts)
    • because the data comes from an aggregation, simplify by always returning the full list (no pagination)
    • allows removing InstitutionImpactList, MockQueryset, api.institutions.renderers

post-deployment notes

after this, should be safe to delete metrics indexes osf_institutionprojectcounts_* and osf_userinstitutionprojectcounts_*

QA Notes

Please make verification statements inspired by your code and what your code touches.

  • Verify institutional dashboard summary and users tabs still work as expected
  • Verify institutional dashboard department lists still work as expected

What are the areas of risk?

  • departments names on the institutional dashboard

Any concerns/considerations/questions that development raised?

Documentation

Side Effects

Ticket

ENG-6223

@aaxelb aaxelb marked this pull request as ready for review October 15, 2025 17:13
@aaxelb aaxelb changed the base branch from develop to feature/pbs-25-21 October 16, 2025 13:43
@aaxelb aaxelb force-pushed the chore/6223-instidash-cleanup branch from e62b86f to c096bf3 Compare October 16, 2025 13:44
@aaxelb aaxelb requested a review from adlius October 16, 2025 14:02
@aaxelb aaxelb force-pushed the chore/6223-instidash-cleanup branch from c096bf3 to a1f8b00 Compare October 16, 2025 14:15
Copy link
Contributor

@Johnetordoff Johnetordoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent work, I couldn't have done it better myself. 🥇

@adlius adlius merged commit c24abb2 into CenterForOpenScience:feature/pbs-25-21 Oct 23, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants