[WIP] Add "page_limit" argument to harvesters #368
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
addresses [#SHARE-50]
erinspace
changed the title
|
I wonder if it might be better to specify the number of times to follow links? That would allow us to choose the minimum number of jumps for our other harvesters to pass |
|
I like that idea. I'll change it so it does that! |
erinspace
changed the title
erinspace
changed the title
There was a problem hiding this comment.
This may have different behavior in python3 (division operator semantics changed slightly, IIRC)
There was a problem hiding this comment.
Also, I would put this check as a condition of the while loop.
There was a problem hiding this comment.
# python3
1 / 2 # 0.5
1 // 2 # 0
# python 2
1 / 2 # 0
1 // 2 # 0
from __future__ import division
1 / 2 # 0.5
1 // 2 # 0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add arg that will grab only a certain number of pages of results. This will help for both local development and test generation, as we can limit the number of results that the test harvesters harvest, and local harvesters take in.