add nih harvester #405
Merged
add nih harvester #405
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[#SHARE-11]
scrapi/harvesters/nih.py
Outdated
Contributor
There was a problem hiding this comment.
You should remove this function.
Contributor
|
1st pass done, looks pretty good. Just had some questions on whether some of the identifying numbers could be turned into URLs. |
Contributor
|
Also, looks like there are some flake8 errors, try running |
added 2 commits
November 2, 2015 16:13
Contributor
|
I don't think you committed the generated response. Also, you'll need a favicon |
jeffreyliu3230
force-pushed
the
feature/nih_harvester
branch
from
07500b5 to
70b0bf0
Compare
Contributor
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[#SHARE-11]