Skip to content

Conversation

kms6bn
Copy link
Contributor

@kms6bn kms6bn commented Apr 1, 2016

removed date from properties list. Also updated language to be read in correctly according to schema.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.1%) to 93.418% when pulling dc2be43 on kms6bn:hotfix/umontreal into 58f6f16 on CenterForOpenScience:master.

@kms6bn kms6bn closed this Apr 1, 2016
@kms6bn kms6bn reopened this Apr 1, 2016
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.1%) to 93.418% when pulling dc2be43 on kms6bn:hotfix/umontreal into 58f6f16 on CenterForOpenScience:master.

@kms6bn kms6bn closed this Apr 1, 2016
@kms6bn kms6bn reopened this Apr 1, 2016
@kms6bn kms6bn closed this Apr 1, 2016
@kms6bn kms6bn reopened this Apr 1, 2016
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.01%) to 93.527% when pulling dc2be43 on kms6bn:hotfix/umontreal into 58f6f16 on CenterForOpenScience:master.

if not languages:
languages = []

return languages

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the original schema, each item in the languages array is transformed to a ISO 639-3 code, for example, 'English' becomes 'eng' and 'Russian' becomes 'rus'. I checked the source and it seems that they were not correctly coded (for example it uses 'en' instead of 'eng'). There is a function get_code in helpers.py that can do that for you. Can you implement it in your function to return the correct code?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Below is the description in the schema:

  • "description": "The primary languages in which the content of the resource is presented. Values used for this element MUST conform to ISO 639\u20133. This offers two and three letter tags e.g. "en" or "eng" for English and "en-GB" for English used in the UK."

You can find all the tags here: https://www.loc.gov/standards/iso639-2/php/code_list.php

It is my understanding that the tags are correct - en maps to English and fr maps to French

Can you confirm that this still needs to be done?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jeffreyliu3230 This is ready to merge, right?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh good find! Yes this should be ready to merge.

@erinspace erinspace merged commit 294480d into CenterForOpenScience:master May 18, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants