fixed python 3 bug #8
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sharepa/analysis.py
Outdated
Contributor
There was a problem hiding this comment.
Best to raise rather than assert, asserts can actually be disabled and therefore ignored in production environments.
Contributor
|
1st pass done 👍 Just 2 super minor comments. Also, it looks like you have fallen out of date with develop, so you'll need to pull it in. |
Contributor
There was a problem hiding this comment.
Could you add a test that causes this error to be raised? You can assert that certain errors are thrown with the assert_raises pytest function:
import pytest
def test_zero_division():
with pytest.raises(ZeroDivisionError):
1 / 0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.