Fix two Reinterop problems with delegates #628
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
j9liu
reviewed
Nov 17, 2025
| )); | ||
|
|
||
| // A a C# delegate type that wraps a std::function, and arrange for | ||
| // A C# delegate type that wraps a std::function, and arrange for |
Contributor
There was a problem hiding this comment.
Typo?
Suggested change
| // A C# delegate type that wraps a std::function, and arrange for | |
| // A C# delegate type that wraps a std::function, and arranges for |
Contributor
There was a problem hiding this comment.
Is it worth noting this change in CHANGES.md?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes two problems with the generated code for delegates.
std::functionis wrapped with a .NET delegate, and the delegate is invoked, that native code could end up throwing an exception. Previously, this exception would have propagated disastrously through the managed code. With this PR, it's caught at the interface layer and turned into a managed exception. Just like it would be (even before this PR) if it were a partial method implemented in native code rather than a delegate.SafeHandleto reference the native function, which meant the delegate could be garbage collected, finalized, and destroy thestd::functionwhile it was running. As described in Native callbacks can be freed while they're running #627.Fixes #627
Sadly this does not fix all the AppDomain unload stability problems. It's still pretty easy to get a crash by entering play mode while tilesets are loading. I think I have a pretty good idea what to do next on that front, though, so I will write it up as a separate issue.