This repository was archived by the owner on May 9, 2024. It is now read-only.
Switch to zeppelin 3.0 #96
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ansermino
commented
Apr 23, 2020
contracts/ERC721Safe.sol
Outdated
Comment on lines
40
to
41
| // TODO: not sure this makes sense | ||
| //_balances[tokenAddress] = _balances[tokenAddress].add(1); |
There was a problem hiding this comment.
Do we need to do any accounting here?
There was a problem hiding this comment.
purely for statistics, not needed.
ansermino
force-pushed
the
david/update-zeppelin
branch
from
b61d483 to
b27735a
Compare
spacesailor24
approved these changes
Apr 23, 2020
ansermino
force-pushed
the
david/update-zeppelin
branch
from
c238b3a to
cb4f549
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Closes: #81