Skip to content
This repository was archived by the owner on Mar 5, 2025. It is now read-only.

Subscribe syncing tests#5005

Closed
avkos wants to merge 1 commit into4.xfrom
5004_Web3.eth.subscribe_syncing_test
Closed

Subscribe syncing tests#5005
avkos wants to merge 1 commit into4.xfrom
5004_Web3.eth.subscribe_syncing_test

Conversation

@avkos
Copy link
Contributor

@avkos avkos commented May 4, 2022

Description

#5004

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • I have selected the correct base branch.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • Any dependent changes have been merged and published in downstream modules.
  • I ran npm run dtslint with success and extended the tests and types if necessary.
  • I ran npm run test:cov and my test cases cover all the lines and branches of the added code.
  • I ran npm run build with success.
  • I have tested the built dist/web3.min.js in a browser.
  • I have tested my code on the live network.
  • I have checked the Deploy Preview and it looks correct.
  • I have updated the CHANGELOG.md file in the root folder.

@jdevcs jdevcs changed the title init subscribe syncing tests May 24, 2022
@jdevcs jdevcs changed the title subscribe syncing tests Subscribe syncing tests May 24, 2022
@jdevcs jdevcs added 4.x 4.0 related In Progress Currently being worked on labels May 24, 2022
@jdevcs jdevcs added the Do Not Merge Not allowed to be merged label Jul 6, 2022
@avkos avkos mentioned this pull request Jul 14, 2022
1 task
@github-actions
Copy link

This PR has been automatically marked as stale beacause it has not had recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions. If you believe this was a mistake, please comment.

@github-actions github-actions bot added the Stale Has not received enough activity label Sep 15, 2022
@github-actions github-actions bot closed this Sep 29, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

4.x 4.0 related Do Not Merge Not allowed to be merged In Progress Currently being worked on Stale Has not received enough activity

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants