Skip to content
This repository was archived by the owner on Mar 5, 2025. It is now read-only.

Conversation

@ghost
Copy link

@ghost ghost commented Jul 24, 2022

Description

Added missing return statement for web3-providers-http, which is under the catch block.

( Might not be very important for someone using promise like me, but would fix the callback calling error twice )

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • I have selected the correct base branch.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • Any dependent changes have been merged and published in downstream modules.
  • I ran npm run dtslint with success and extended the tests and types if necessary.
  • I ran npm run test:cov and my test cases cover all the lines and branches of the added code.
  • I ran npm run build with success.
  • I have tested the built dist/web3.min.js in a browser.
  • I have tested my code on the live network.
  • I have checked the Deploy Preview and it looks correct.
  • I have updated the CHANGELOG.md file in the root folder.

@coveralls
Copy link

coveralls commented Jul 24, 2022

Pull Request Test Coverage Report for Build 2727583403

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+0.004%) to 74.603%

Files with Coverage Reduction New Missed Lines %
packages/web3-providers-http/lib/index.js 1 77.36%
Totals Coverage Status
Change from base Build 2697072063: 0.004%
Covered Lines: 3270
Relevant Lines: 4132

💛 - Coveralls

@ghost ghost closed this Aug 15, 2022
This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant