Sample Tests via Foundry-Anvil #1208
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
auto-assign
bot
requested review from
creeppak,
juans-chainsafe,
kantagara and
sneakzttv
rob1997
added
the
ready-to-merge
Contributor
|
@rob1997 is this Pull Request Checks / Unity Tests 🧪 / Unity Tests 🧪 (src/UnitySampleProject, PlayMode) (pull_request) Failing after 3m Meant to fail? :D |
rob1997
added
ready-to-merge
rob1997
force-pushed
the
rob/move-tests-to-anvil-625
branch
2 times, most recently
from
eb1fcf9 to
a8562c8
Compare
rob1997
added
ready-to-merge
rob1997
force-pushed
the
rob/move-tests-to-anvil-625
branch
from
98b0fe8 to
cd3fc46
Compare
rob1997
force-pushed
the
rob/move-tests-to-anvil-625
branch
from
cd3fc46 to
c67b94b
Compare
creeppak
reviewed
Oct 31, 2024
| object[] args = | ||
| { | ||
| Web3Unity.Web3.Signer.PublicAddress | ||
| Web3Unity.Instance.Address |
Contributor
There was a problem hiding this comment.
I'd say Address is not descriptive enough as it can mean any address in the context of Web3Unity. Something like PlayerAddress is more suiting imo.
Collaborator
Author
There was a problem hiding this comment.
Hmm I suppose yeah, this makes me think I don't think Web3Unity supports connecting multiple acoounts @kantagara what do you think of this as a feature?
Contributor
There was a problem hiding this comment.
Maybe it should be called PublicAddress.
In regards to multiple accounts -> That is something I think we will have to support for our upcoming partnership with you guys know who, so it will be a nice integration. Wouldn't like to use it by default tho in the main branch so to say :D
Collaborator
Author
There was a problem hiding this comment.
Yep my bad, changed now
rob1997
force-pushed
the
rob/move-tests-to-anvil-625
branch
from
c69784d to
74b264e
Compare
rob1997
added
ready-to-merge
rob1997
force-pushed
the
rob/move-tests-to-anvil-625
branch
2 times, most recently
from
8641c9c to
f19d9c2
Compare
rob1997
added
ready-to-merge
Contributor
|
Unity tests again failing? :D |
Collaborator
Author
They're meant to fail because we're referencing CI on main when Tests are expecting the one on this branch, I've added a test run I did with a push trigger on main in the PRs description, once it's merged it'll get what it's expecting |
rob1997
force-pushed
the
rob/move-tests-to-anvil-625
branch
from
3c3cb66 to
7e4a0bb
Compare
rob1997
added
ready-to-merge
juans-chainsafe
suggested changes
Nov 4, 2024
Contributor
juans-chainsafe
left a comment
juans-chainsafe
left a comment
There was a problem hiding this comment.
Things working in WebGL and iOS! Just a couple of things:
- Remove Anvil from connection providers
- Balance of fails if we try it without a wallet connected because is getting the balance of the current wallet:
Web3Exception: Can't get player address. No Signer was provided during construction.
ChainSafe.Gaming.Evm.Contracts.BuiltIn.Erc20Contract.EnsureSigner () (at <4e129708b90a4f2a88fe3629bf8dff3a>:0)
ChainSafe.Gaming.Evm.Contracts.BuiltIn.Erc20Contract.GetBalanceOf () (at <4e129708b90a4f2a88fe3629bf8dff3a>:0)
ChainSafe.Gaming.Evm.Contracts.BuiltIn.Erc20Service.GetBalanceOf (System.String contractAddress) (at <4e129708b90a4f2a88fe3629bf8dff3a>:0)
Erc20Sample.BalanceOf () (at Assets/Samples/web3.unity SDK/3.0.5/Web3.Unity Samples/Scripts/Samples/Erc20Sample.cs:57)
Samples.TryExecute (System.Reflection.MethodInfo method, ChainSafe.Gaming.ISample instance) (at /Users/juanmanuelspoleti/Desktop/workspace/web3.unity/Packages/io.chainsafe.web3-unity/Runtime/Scripts/Samples/Samples.cs:92)
System.Runtime.CompilerServices.AsyncMethodBuilderCore+<>c.<ThrowAsync>b__7_0 (System.Object state) (at <606c2e0a56af495988c860a4ac613e74>:0)
UnityEngine.UnitySynchronizationContext+WorkRequest.Invoke () (at /Users/bokken/build/output/unity/unity/Runtime/Export/Scripting/UnitySynchronizationContext.cs:153)
UnityEngine.UnitySynchronizationContext.Exec () (at /Users/bokken/build/output/unity/unity/Runtime/Export/Scripting/UnitySynchronizationContext.cs:83)
UnityEngine.UnitySynchronizationContext.ExecuteTasks () (at /Users/bokken/build/output/unity/unity/Runtime/Export/Scripting/UnitySynchronizationContext.cs:107)
f862019 to
74a56b8
Compare
rob1997
added
ready-to-merge
Collaborator
Author
Nice catch! requested changes made |
juans-chainsafe
approved these changes
Nov 5, 2024
Contributor
juans-chainsafe
left a comment
juans-chainsafe
left a comment
There was a problem hiding this comment.
Both issues were fixed!
creeppak
approved these changes
Nov 5, 2024
rob1997
added a commit
that referenced
this pull request
Jan 16, 2025
* anvil working/integrated but tests still failing * working sample tests * some cleanup and refactor * checkpoint * checkpoint * moved some dependencies down * fixed async issue * Gelato tests * documentation and cleanup * updated workflow to use foundry * submodules update on checkout * trigger on push * log exceptions for initialize * dependencies * 172.17.0.1 * allowing http * dependable dependencies and verbose connection error exception * added --host 0.0.0.0 to anvil * reverted dependencies and push trigger * start and use anvil when in windows * remove pdb meta files * added events service adapter to Web3Unity_Tests.prefab * resolve conflict * merge fixed * small edit * requested changes made * Duplicated Samples [skip ci] * Sync Dependencies - Auto Commit --------- Co-authored-by: rob1997 <rob1997@users.noreply.github.com> Co-authored-by: Nikola Garabandic <kantagara@gmail.com>
sergeypanin1994
pushed a commit
to sergeypanin1994/web3.unity
that referenced
this pull request
Mar 16, 2025
* anvil working/integrated but tests still failing * working sample tests * some cleanup and refactor * checkpoint * checkpoint * moved some dependencies down * fixed async issue * Gelato tests * documentation and cleanup * updated workflow to use foundry * submodules update on checkout * trigger on push * log exceptions for initialize * dependencies * 172.17.0.1 * allowing http * dependable dependencies and verbose connection error exception * added --host 0.0.0.0 to anvil * reverted dependencies and push trigger * start and use anvil when in windows * remove pdb meta files * added events service adapter to Web3Unity_Tests.prefab * resolve conflict * merge fixed * small edit * requested changes made * Duplicated Samples [skip ci] * Sync Dependencies - Auto Commit --------- Co-authored-by: rob1997 <rob1997@users.noreply.github.com> Co-authored-by: Nikola Garabandic <kantagara@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We're now testing samples themselves via anvil and reflection.
Removed old tests and a bunch of unused scripts in Samples.
Unity tests will fail because we're referencing workflows on main but here is a successful run for testing https://github.com/ChainSafe/web3.unity/actions/runs/11662595176