Countly warnings #1268
Merged
Countly warnings #1268
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sneakzttv
added
ready-to-merge
auto-assign
bot
requested review from
creeppak,
juans-chainsafe,
kantagara and
rob1997
juans-chainsafe
approved these changes
Jan 8, 2025
Contributor
juans-chainsafe
left a comment
juans-chainsafe
left a comment
There was a problem hiding this comment.
no countly warnings are displayed and webgl is working, but I suggest recheck after the other warning PR gets fixed and merged
Contributor
Author
|
Ok good call, I'll wait and merge this one last to be safe. Will ping you when it's ready to check again. |
kantagara
approved these changes
Jan 9, 2025
sneakzttv
added
ready-to-merge
sneakzttv
added
ready-to-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Countly warning fixes
Enabled nullable references.
Disabled timezone check in TimeMetric with pragma comment.
Removed obsolete identifiers as we're not changing the properties, just referencing them.
Removed an unused async function modifier.
Closes #1221
Testing:
Right click in the folder hierarchy in the unity editor and press import all to reimport files to trigger the recompile.
Expected Result:
No countly warnings will appear.
No documentation changes are needed for this PR.