fix: allow undefined symbols during build time#1
Merged
wemeetagain merged 2 commits intoChainSafe:mainfrom Dec 12, 2025
Merged
Conversation
Previously, building would fail because zig expects the napi symbols during link time when they actually only exist during runtime. This PR relaxes this with the `allow-shlib-undefined` option (see: [`ld` docs](https://www.man7.org/linux/man-pages/man1/ld.1.html)).
spiral-ladder
commented
Dec 11, 2025
| .name = "napi", | ||
| .root_module = module_napi, | ||
| .filters = &[_][]const u8{}, | ||
| .filters = b.option([][]const u8, "napi.filters", "napi test filters") orelse &[_][]const u8{}, |
Contributor
Author
There was a problem hiding this comment.
this change was made from using a newer version of zbuild (same for below)
wemeetagain
reviewed
Dec 11, 2025
spiral-ladder
force-pushed
the
bing/fix-undefined-symbols
branch
from
0162a91 to
a6cac0e
Compare
wemeetagain
approved these changes
Dec 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, building would fail because zig expects the napi symbols during link time when they actually only exist during runtime. This PR relaxes this with the
allow-shlib-undefinedoption (see:lddocs).