Skip to content

Conversation

@anderslindho
Copy link
Contributor

No description provided.


@Operation(
summary = "Process channels by query",
description = "Manually trigger processing on channels matching the given query.",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we add here what kind of keywords can be used in the query? Like:
You can use the following keywords as search parameters to filter on specific fields:
- ~name
- ~tag
- ~size
- ~from

        You can use the '!' character at the end of keyword to negate the filtering expression
        (for used keywords only tag can have negating). e.g.: ~tag!
        
        You can use the following characters as dividers for searching for values: [|,;]

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess that should be done through @Parameter annotations, but here only a single one for all params (due to MultiValueMap<String, String>)?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, Imre pointed out in the last pr that unfortunately changing the multivaluemap would break the API. So for now the best way is to add the information in the operation or the parameter description

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah I see that too. Maybe we should have a backlog ticket to at least record this - I assume we will want to change it for a v2 API?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess the param annotation really should be in the query methods in ChannelManager and ChannelScroll instead of on the processor, or?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah I see that too. Maybe we should have a backlog ticket to at least record this - I assume we will want to change it for a v2 API?

I think so yes, but v2 API I think we should try design from scratch

I guess the param annotation really should be in the query methods in ChannelManager and ChannelScroll instead of on the processor, or?

Also here on the processor I think

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Turns out it was relevant in even more places, so I extracted the message into a var. Harms readability a little bit, but at least the descriptions should not diverge now.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Jun 9, 2025

@jacomago jacomago merged commit e7d7553 into ChannelFinder:master Jun 9, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants