Add 'size' and 'ifrom' keyword parameters for 'find' method #21
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is trying to fit the new feature of CF service, in which *size* and *from* is two new arguments for restful API. Here in Python client, using *ifrom* instead of *from*, since the latter one is reserved by Python.
shroffk
approved these changes
Aug 3, 2017
|
The CI task needs to be replaced with a new travis setup |
|
Probably, Travis CI needs a Channel Finder service container image? |
|
yup, I will merge this and setup the travis CI separately |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is trying to fit the new feature of CF service, in which
size and from is two new arguments for restful API.
Here in Python client, using ifrom instead of from, since the
latter one is reserved by Python.