Skip to content

Conversation

mark0n
Copy link
Contributor

@mark0n mark0n commented Apr 20, 2018

This fixes #24.

@mark0n
Copy link
Contributor Author

mark0n commented Apr 20, 2018

The failing test doesn't seem to be related to my change.

@shroffk
Copy link
Contributor

shroffk commented Apr 20, 2018

yes, that is fine...the error is due to the absence of the .travis file

@shroffk
Copy link
Contributor

shroffk commented Apr 20, 2018

were you able to successfully use the client with the channelfinder service.

@mark0n
Copy link
Contributor Author

mark0n commented Apr 21, 2018

I wasn't able to test with master due to some unrelated changes which broke it (at least for my environment). But using a slightly older version (cccf67b), I was able to verify that my change works (connects fine, I get the expected result).

@shroffk
Copy link
Contributor

shroffk commented Apr 23, 2018

Ok great,
I will merge this then @shengb

@shroffk shroffk merged commit b601061 into ChannelFinder:master Apr 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Disable SSLv2/3

2 participants