0.5 use optionals #40
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…echniques/intention-revealing-code-java-8-optional/) Request handling chain now explicitly throws UnsupportedFeatureException if feature is not found IllegalStateException thrown if active session not found while handling incoming request Communicating internal error if confirmation type is not found Added debug log messages if promise is not found Added debug log messages with request queue size Added debug log messages if feature or request not found while handling incoming confirmation Added warning log message if active session is not found before closing connection Added warning log message if confirmation type was not found
TVolden
approved these changes
Apr 16, 2018
|
Hi Evgeny, I must say I'm impressed with all the work you put into it. Thanks. Thomas |
|
Hi Thomas,
Thanks for implementing the OCPP spec in Java and sharing it in the first
place.
We are about to use OCPP in ubitricity and decided to pick up the
implementation.
So I thought instead of just forking cooperation would be beneficial.
Eugene
2018-04-16 8:40 GMT+02:00 Thomas Volden <notifications@github.com>:
… Hi Evgeny,
I must say I'm impressed with all the work you put into it. Thanks.
I'll try to read and verify everything today.
Thomas
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#40 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AOpUGKkx9VsTq6VHftsqfXflxGQuhqWEks5tpDzSgaJpZM4TVubV>
.
--
С уважением
Евгений
|
|
How nice of you, I really appreciate that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.