Skip to content
This repository was archived by the owner on Jun 20, 2025. It is now read-only.

Conversation

@juliangruber
Copy link
Member

@juliangruber juliangruber requested a review from bajtos June 17, 2024 10:19
@juliangruber
Copy link
Member Author

@bajtos hindsight please

@juliangruber juliangruber merged commit 68a1e62 into main Jun 17, 2024
@juliangruber juliangruber deleted the fix/dependabot-main-deploy branch June 17, 2024 10:20
Copy link
Member

@bajtos bajtos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤦🏻

Thank you for finding a way how to make this work!

@bajtos
Copy link
Member

bajtos commented Jun 20, 2024

Should we deploy this fix to all other GH repos that are automatically deployed to Fly.io from the main branch? I think they are subject to the same problem.

  • spark-api
  • spark-evaluate
  • spark-stats
  • Anything else?

@juliangruber
Copy link
Member Author

I think yes, at it's a blind spot and unexpected behavior

@bajtos
Copy link
Member

bajtos commented Sep 6, 2024

@juliangruber I don't remember in which issue we discussed this problem earlier this week.

AFAICT, dependabot updates are still not triggering deployment from the main branch.

Screenshot 2024-09-06 at 10 28 58

PR not deployed: #54

@bajtos
Copy link
Member

bajtos commented Sep 6, 2024

The commit that did not trigger our CI & CD workflow:
3b11a2b

@juliangruber
Copy link
Member Author

Ok trying c6c2022. It was still committing as dependabot[bot]

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants