This repository was archived by the owner on Jun 30, 2025. It is now read-only.
metrics: Fix optional module name api #118
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bajtos
approved these changes
May 3, 2023
README.md
Outdated
| Returns `Promise<MetricsEvent>`. | ||
|
|
||
| ### `Core#metrics.follow(module?: String, { signal?: AbortSignal })` | ||
| ### `Core#metrics.follow({ module?: String, signal?: AbortSignal })` |
Member
There was a problem hiding this comment.
Is it possible to omit both property args and call follow with no arguments at all?
core.metrics.follow()Maybe we can signal that option by adding ? after the object.
### `Core#metrics.follow({ module?: String, signal?: AbortSignal }?)`Or perhaps:
### `Core#metrics.follow({ module?: String, signal?: AbortSignal } = {})`
Member
Author
There was a problem hiding this comment.
Yes it's possible. I had the = {} before, but it got too verbose for my taste. Will try again
Member
Author
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.