add $ARCH to install script
#154
Conversation
| repo, | ||
| distTag, | ||
| executable, | ||
| arch = os.arch(), |
There was a problem hiding this comment.
this argument wasn't being used any more
There was a problem hiding this comment.
I am concerned about setting the arch deep inside this file. When reading the top-level post-install script, it's not clear that we may be downloading different files based on some environment variables.
Would you mind keeping arch here, maybe as a required argument, and setting it from env vars in the file where we are calling getBinaryModuleExecutable?
There was a problem hiding this comment.
good idea, like this?
| repo, | ||
| distTag, | ||
| executable, | ||
| arch = os.arch(), |
There was a problem hiding this comment.
I am concerned about setting the arch deep inside this file. When reading the top-level post-install script, it's not clear that we may be downloading different files based on some environment variables.
Would you mind keeping arch here, maybe as a required argument, and setting it from env vars in the file where we are calling getBinaryModuleExecutable?
Required for CheckerNetwork/desktop#767