telemetry: also search err.code

[juliangruber]

Previously we weren't successfully filtering out errors like ones with .code = 'ECONNRESET', because the String(err) only includes the message, no other properties:

> const err = new Error('message')
> err.code = 'ECONNRESET'
> String(err)
> // => Error: message

util.inspect() fixes this:

> util.inspect(err)
'Error: message\n' +
  '    at REPL22:1:11\n' +
  '    at Script.runInThisContext (node:vm:122:12)\n' +
  '    at REPLServer.defaultEval (node:repl:567:29)\n' +
  '    at bound (node:domain:433:15)\n' +
  '    at REPLServer.runBound [as eval] (node:domain:444:12)\n' +
  '    at REPLServer.onLine (node:repl:897:10)\n' +
  '    at REPLServer.emit (node:events:523:35)\n' +
  '    at REPLServer.emit (node:domain:489:12)\n' +
  '    at [_onLine] [as _onLine] (node:internal/readline/interface:415:12)\n' +
  '    at [_line] [as _line] (node:internal/readline/interface:886:18) {\n' +
  "  code: 'ECONNRESET'\n" +
  '}'

A potential downside is that it includes the stack, which could lead to false positives. If we only want to add the .code property, this would work as an alternative. @bajtos which do you think is better?

> String(err + err?.code)
'Error: messageECONNRESET

[bajtos]

I guess inspect is good enough. We can replace it when it becomes a problem.

But I do have a suggestion to consider 👇🏻

[bajtos]

How about applying the check on the error code string directly?

if (unactionableErrors.test(String(err))) return;
if (err?.code && unactionableErrors.test(String(err.code))) return;
Sentry.captureException(err)

[juliangruber]

I really like this, even simpler!