Skip to content
This repository was archived by the owner on Jun 30, 2025. It is now read-only.

Conversation

@juliangruber
Copy link
Member

@juliangruber juliangruber commented Apr 9, 2024

Screenshot 2024-04-09 at 16 27 57

There's nothing that operators can do about these crashes. This PR changes the activity type into "Info"

@juliangruber juliangruber requested a review from bajtos April 9, 2024 14:28
Copy link
Member

@bajtos bajtos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TBH, this feels very hacky to me. I prefer to handle these crashes in such a way that no activity logs are created. However, that requires quite a bit of work, starting in Zinnia. In this light, it's best to land this fix as a quick stop-gap solution.

@bajtos
Copy link
Member

bajtos commented Apr 11, 2024

Created a Zinnia feature request here:

@juliangruber
Copy link
Member Author

I very much agree!

@juliangruber juliangruber enabled auto-merge (squash) April 11, 2024 08:30
@juliangruber juliangruber disabled auto-merge April 11, 2024 09:56
@juliangruber juliangruber merged commit ad71623 into main Apr 11, 2024
@juliangruber juliangruber deleted the fix/voyager-error-display branch April 11, 2024 09:56
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants