Skip to content
This repository was archived by the owner on Jun 30, 2025. It is now read-only.

Conversation

@bajtos
Copy link
Member

@bajtos bajtos commented Apr 18, 2024

  • chore: fix TypeScript errors related to pipeline
  • ci: add TypeScript check to the CI workflow

This is a follow-up for #410

bajtos added 2 commits April 18, 2024 11:48
Suppress type-checking for `pipeline` arguments because the types
provided by npm packages for our stream arguments are considered as
incompatible with Node.js ReadableStream and WritableStream types
expected by the `pipeline` function.

Signed-off-by: Miroslav Bajtoš <oss@bajtos.net>
Signed-off-by: Miroslav Bajtoš <oss@bajtos.net>
@bajtos bajtos requested a review from juliangruber April 18, 2024 09:54
Copy link
Member

@juliangruber juliangruber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you so much Miro!

@bajtos bajtos merged commit 2bc80c2 into main Apr 18, 2024
@bajtos bajtos deleted the fix-types branch April 18, 2024 10:47
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants