Skip to content
This repository was archived by the owner on Jun 30, 2025. It is now read-only.

Conversation

@juliangruber
Copy link
Member

For CheckerNetwork/desktop#1726

I decided to add this flag instead of a new exit code (as suggested in CheckerNetwork/desktop#1726 (comment)), because with the new exit code Station Desktop needs to know where Station Core stores its internal files, and this coupling isn't necessary.

@juliangruber
Copy link
Member Author

Blocks CheckerNetwork/desktop#1742

Copy link
Member

@bajtos bajtos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@juliangruber juliangruber requested a review from bajtos August 2, 2024 05:39
Copy link
Member

@bajtos bajtos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌🏻

What do you think about improving the following error message to explain to the user that they can re-run Station Core with the new flag to fix the problem?

https://github.com/filecoin-station/core/blob/fe02c6e4e10f043743a640c6fc807c4af8f76c8f/lib/station-id.js#L64

@juliangruber
Copy link
Member Author

Great idea!

@juliangruber juliangruber merged commit f9b5cc7 into main Aug 2, 2024
@juliangruber juliangruber deleted the add/recreate-station-id-on-error branch August 2, 2024 09:26
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants