api: Add fixed # tasks per round. Closes space-meridian/roadmap#82 #385
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
Using live data, this will decrease the job count by a lot. We might want to update the target job volume |
bajtos
requested changes
Aug 2, 2024
Member
bajtos
left a comment
bajtos
left a comment
There was a problem hiding this comment.
Great start!
Do we need to test this code path?
Yes, please. Otherwise, how can we verify that the algorithm works as intended?
juliangruber
commented
Sep 9, 2024
bajtos
reviewed
Sep 9, 2024
bajtos
requested changes
Sep 9, 2024
22 tasks
bajtos
requested changes
Sep 16, 2024
Member
bajtos
left a comment
bajtos
left a comment
There was a problem hiding this comment.
Nice! I think the proposed algorithm should work well 👍🏻
I'd like to improve a few minor details, PTAL below.
20 tasks
Member
Author
|
Thanks! Will ship tomorrow |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes CheckerNetwork/roadmap#82
Depends on CheckerNetwork/spark-stats#214
Alternatives considered:
Base task count on measurement count from previous round. This data doesn't exist in spark-stats yet. It should lead to better results though, than the currently used station-id count. @bajtos wdyt? Shall we give this a try and see if it behaves well enough?We went with this alternativeQuestions:
Do we need to test this code path?YesTODO