AST-37667 added ability to send the agent in the results command #322
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…splay the container results
cx-tamar-levi
requested review from
OrShamirCM,
checkmarx-kobi-hagmi and
cx-ben-alvo
cx-pedro-lopes
requested review from
a team,
cx-pedro-lopes and
danielcaldeiracx
and removed request for
a team
Contributor
|
Policy Management Violations
No New Or Fixed Issues Found |
checkmarx-kobi-hagmi
approved these changes
May 9, 2024
OrShamirCM
reviewed
May 9, 2024
| arguments.add(CxConstants.OUTPUT_NAME); | ||
| arguments.add(fileName); | ||
| arguments.add(CxConstants.OUTPUT_PATH); | ||
| arguments.add(tempDir); |
Contributor
There was a problem hiding this comment.
Let's talk about the PR. Im thinking to have a default call for wrappers, as Plugins maybe
OrShamirCM
reviewed
May 9, 2024
OrShamirCM
reviewed
May 9, 2024
| throws IOException, InterruptedException, CxException { | ||
| return results(scanId, reportFormat, null); | ||
| } | ||
| public String results(@NonNull UUID scanId, ReportFormat reportFormat, String agent) |
Contributor
There was a problem hiding this comment.
this is a private method which means the plugin will not see the new contract. I'm not sure it's the right thing to do.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://checkmarx.atlassian.net/browse/AST-37667
added ability to send the agent to the results command
the agent used in the results command to display/hide the container results