Skip to content

Update triageGetStates method to return CustomState and remove test ignore #403

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 18, 2025
Merged

Update triageGetStates method to return CustomState and remove test ignore #403

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions src/main/java/com/checkmarx/ast/wrapper/CxWrapper.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -166,7 +166,7 @@ public List<Predicate> triageShow(@NonNull UUID projectId, String similarityId,
return Execution.executeCommand(withConfigArguments(arguments), logger, Predicate::listFromLine, Predicate::validator);
}

public List<Predicate> triageGetStates(boolean all) throws IOException, InterruptedException, CxException {
public List<CustomState> triageGetStates(boolean all) throws IOException, InterruptedException, CxException {
this.logger.info("Executing 'triage get-states' command using the CLI.");

List<String> arguments = new ArrayList<>();
Expand All @@ -187,7 +187,6 @@ public void triageUpdate(@NonNull UUID projectId, String similarityId, String sc
this.logger.info("Executing 'triage update' command using the CLI.");
this.logger.info("Updating the similarityId {} with state {} with customStateId {} and severity {}.", similarityId, state, customStateId, severity);

boolean emptyState = state == null || state.isEmpty();
boolean emptyCustomStateId = customStateId == null || customStateId.isEmpty();

List<String> arguments = new ArrayList<>();
Expand Down
5 changes: 2 additions & 3 deletions src/test/java/com/checkmarx/ast/PredicateTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,11 @@
package com.checkmarx.ast;

import com.checkmarx.ast.predicate.CustomState;
import com.checkmarx.ast.predicate.Predicate;
import com.checkmarx.ast.results.Results;
import com.checkmarx.ast.results.result.Result;
import com.checkmarx.ast.scan.Scan;
import com.checkmarx.ast.wrapper.CxConstants;
import org.junit.Ignore;
import org.junit.jupiter.api.Assertions;
import org.junit.jupiter.api.Disabled;
import org.junit.jupiter.api.Test;
Expand Down Expand Up @@ -48,9 +48,8 @@ void testTriage() throws Exception {
}

@Test
@Disabled("Ignore this tests until get states api will be in production")
void testGetStates() throws Exception {
List<Predicate> states = wrapper.triageGetStates(false);
List<CustomState> states = wrapper.triageGetStates(false);
Assertions.assertNotNull(states);
}
}