JS Wrapper | Remove CLI from the wrapper and download from S3 (AST-64803) #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OrShamirCM
commented
Sep 24, 2024
src/main/wrapper/CxWrapper.ts
Outdated
| } | ||
|
|
||
| initializeCommands(formatRequired: boolean): string[] { | ||
| async initializeCommands(formatRequired: boolean): Promise<string[]> { |
Author
There was a problem hiding this comment.
when is get to this method? in each command and each event or only one time?
| } | ||
| let executablePath: string; | ||
| if (cxScanConfig.pathToExecutable) { | ||
| this.config.pathToExecutable = cxScanConfig.pathToExecutable; |
Author
There was a problem hiding this comment.
you can create a factory for the wrapper then have async method for init the wrapper
Author
There was a problem hiding this comment.
or you can create just a method in the wrapper create wrapper that will call the constructor and init the cli
Author
There was a problem hiding this comment.
fyi, there are more ways to solve it, you can try to get the right solution
cx-ben-alvo
reviewed
Sep 24, 2024
cx-ben-alvo
reviewed
Sep 24, 2024
cx-ben-alvo
reviewed
Sep 24, 2024
cx-ben-alvo
approved these changes
Sep 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.