feature improve logs #25
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
diogopcx
reviewed
Oct 19, 2021
Contributor
diogopcx
left a comment
diogopcx
left a comment
There was a problem hiding this comment.
I have some doubts that I'm not sure are actual issues but I would like to clarify.
In package.json the version is set to 0.0.32 but in package-lock.json it is set to 0.0.41.
I agree on committing the package-lock but should these match?
Also, I noticed in both files there is a dependency to the wrapper itself, is this correct?
Contributor
Author
|
You were right! I think it is correct now, thanks. |
…i-javascript-wrapper into feature/improve_logs
Contributor
|
No Violations Found |
diogopcx
approved these changes
Oct 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding the auth validate to the wrapper, so that It can be used in the vs code plugin.