Skip to content

AST-43037 push version tag through PR #641

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jun 9, 2024
Merged

AST-43037 push version tag through PR #641

merged 4 commits into from
Jun 9, 2024

Conversation

@cx-tamar-levi
Copy link
Collaborator

@cx-tamar-levi cx-tamar-levi commented May 30, 2024 •
edited
Loading

https://checkmarx.atlassian.net/browse/AST-43037

fix the release.yml

Instead of pushing directly to the main branch, we now do the following steps:

  • push the changes that become from the updating of the version in the package.json and package-lock.json to a new branch
  • push the new tag also to the branch
  • open a PR
  • merge the PR to 'main' with the personal token (Or token)

@cx-pedro-lopes cx-pedro-lopes requested review from a team, cx-cristovao-castro and cx-hugo-machado and removed request for a team May 30, 2024 11:48
@cx-tamar-levi cx-tamar-levi marked this pull request as ready for review May 30, 2024 12:42
@cx-pedro-lopes cx-pedro-lopes requested a review from a team May 30, 2024 12:42
@cx-tamar-levi cx-tamar-levi added the github_actions Pull requests that update GitHub Actions code label Jun 2, 2024
OrShamirCM
OrShamirCM reviewed Jun 4, 2024
View reviewed changes
@cx-tamar-levi cx-tamar-levi merged commit 5cb233b into main Jun 9, 2024
@cx-tamar-levi cx-tamar-levi deleted the create-pr-to-update-version branch June 9, 2024 11:27
@cx-tamar-levi cx-tamar-levi restored the create-pr-to-update-version branch June 20, 2024 07:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cx-hugo-machado cx-hugo-machado Awaiting requested review from cx-hugo-machado cx-hugo-machado was automatically assigned from CheckmarxDev/ast-plugins

@cx-cristovao-castro cx-cristovao-castro Awaiting requested review from cx-cristovao-castro cx-cristovao-castro was automatically assigned from CheckmarxDev/ast-plugins

@cx-pedro-lopes cx-pedro-lopes Awaiting requested review from cx-pedro-lopes

1 more reviewer

@OrShamirCM OrShamirCM OrShamirCM approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

github_actions Pull requests that update GitHub Actions code

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@cx-tamar-levi @OrShamirCM