Add Custom States Support (AST-83449, AST-83450) #311
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cx-ben-alvo
requested review from
cx-daniel-greenspan and
cx-miryam-foifer
as code owners
|
Great job, no security vulnerabilities found in this Pull Request |
…ically and improve filter retrieval logic
… streamline filter management
…lter initialization and retrieval logic
…ith default filters if custom states retrieval fails
…hod for improved filter management
…ved filter integration
…reshScanGroup method
cx-ben-alvo
changed the title
…state management and filtering
…ate CxToolWindowPanel to reset custom filters
…ass that will manage all the communication with the wrapper and the DynamicState Action
| .map(CustomResultState::getLabel) | ||
| .collect(Collectors.toUnmodifiableSet()); | ||
|
|
||
| private static List<CustomStateFilter> customStateFilters; |
There was a problem hiding this comment.
Is there a potential race condition with the static "customStateFilters" variable
There was a problem hiding this comment.
No because the plugin is not multithread
| import static com.checkmarx.intellij.ui.utils.Xpath.*; | ||
|
|
||
| public class TestGeneral extends BaseUITest { | ||
| List<String> defaultState = List.of("CONFIRMED", "TO_VERIFY", "URGENT", "NOT_EXPLOITABLE", "PROPOSED_NOT_EXPLOITABLE", "IGNORED", "NOT_IGNORED"); |
There was a problem hiding this comment.
we have a test to coverage for the custom states functionality?
There was a problem hiding this comment.
Not yet because it's not in deu
…agement - Make it Singleton
cx-elchanan-arbiv
approved these changes
Feb 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By submitting a PR to this repository, you agree to the terms within the Checkmarx Code of Conduct. Please see the contributing guidelines for how to create and submit a high-quality PR for this repo.
Description
References
Testing
Checklist