Skip to content

fix(query): fix FP results on "IAM policy allows for data exfiltration" CloudFormation and Terraform queries #8030

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
cx-andre-pereira wants to merge 4 commits into
base: master
Choose a base branch
from
Open

fix(query): fix FP results on "IAM policy allows for data exfiltration" CloudFormation and Terraform queries #8030

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
b5c4a3d
Added missing check/associated tests to cloudFormation and Terraform …
cx-andre-pereira Apr 8, 2026
c880fb3
Merge branch 'master' of https://github.com/Checkmarx/kics into AST-1…
cx-andre-pereira Apr 8, 2026
b259f59
Trying to make file changes clearer on gitdiff
cx-andre-pereira Apr 8, 2026
121501a
Merge branch 'master' into AST-145579_FP_on_IAM_Policy_Allows_For_Dat…
cx-artur-ribeiro Apr 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions assets/queries/cloudFormation/aws/iam_policy_allows_for_data_exfiltration/query.rego
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,20 +3,21 @@ package Cx
import data.generic.common as common_lib
import data.generic.cloudformation as cf_lib

ilegal_actions := ["s3:GetObject", "ssm:GetParameter", "ssm:GetParameters", "ssm:GetParametersByPath", "secretsmanager:GetSecretValue","*","s3:*"]
ilegal_actions := ["s3:GetObject", "ssm:GetParameter", "ssm:GetParameters", "ssm:GetParametersByPath", "secretsmanager:GetSecretValue","*","s3:*"]

CxPolicy[result] {
types := ["AWS::IAM::Group", "AWS::IAM::Role", "AWS::IAM::User"]

resource := input.document[i].Resources[name]
resource.Type == types[_]

policy := resource.Properties.Policies[i2].PolicyDocument
st := common_lib.get_statement(common_lib.get_policy(policy))
statement := st[st_index]

common_lib.is_allow_effect(statement)
ilegal_action := is_ilegal(statement.Action)
common_lib.equalsOrInArray(statement.Resource, "*")

result := {
"documentId": input.document[i].id,
Expand All @@ -41,6 +42,7 @@ CxPolicy[result] {

common_lib.is_allow_effect(statement)
ilegal_action := is_ilegal(statement.Action)
common_lib.equalsOrInArray(statement.Resource, "*")

result := {
"documentId": input.document[i].id,
Expand Down
30 changes: 30 additions & 0 deletions ...s/queries/cloudFormation/aws/iam_policy_allows_for_data_exfiltration/test/negative11.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,30 @@
{
"Resources": {
"CFNUser": {
"Type": "AWS::IAM::User",
"Properties": {
"LoginProfile": {
"Password": "Password",
"PasswordResetRequired": false
},
"Policies": [
{
"PolicyName": "root",
"PolicyDocument": {
"Version": "2012-10-17",
"Statement": [
{
"Effect": "Allow",
"Action": [
"*"
],
"Resource": "arn:aws:dynamodb:us-east-1:123456789012:table/Users"
}
]
}
}
]
}
}
}
}
16 changes: 16 additions & 0 deletions ...s/queries/cloudFormation/aws/iam_policy_allows_for_data_exfiltration/test/negative12.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,16 @@
Resources:
CFNUser:
Type: AWS::IAM::User
Properties:
LoginProfile:
Password: 'Password'
PasswordResetRequired: false
Policies:
- PolicyName: root
PolicyDocument:
Version: "2012-10-17"
Statement:
- Effect: Allow
Action:
- '*'
Resource: 'arn:aws:dynamodb:us-east-1:123456789012:table/Users'
2 changes: 1 addition & 1 deletion ...s/queries/cloudFormation/aws/iam_policy_allows_for_data_exfiltration/test/positive12.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
{
"Effect": "Allow",
"Action": "secretsmanager:GetSecretValue",
"Resource": "*"
"Resource": ["arn:aws:dynamodb:us-east-1:123456789012:table/Users", "*"]
}
]
}
Expand Down
4 changes: 3 additions & 1 deletion ...ts/queries/cloudFormation/aws/iam_policy_allows_for_data_exfiltration/test/positive5.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,9 @@ Resources:
Statement:
- Effect: Allow
Action: "s3:*"
Resource: "*"
Resource:
- "arn:aws:dynamodb:us-east-1:123456789012:table/Users"
- "*"
Users:
- TestUser
Description: "Policy for creating a test database"
4 changes: 4 additions & 0 deletions assets/queries/terraform/aws/iam_policy_allows_for_data_exfiltration/query.rego
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@ CxPolicy[result] { # resources
statement := st[st_index]
common_lib.is_allow_effect(statement)
illegal_action := is_illegal(statement.Action)
common_lib.equalsOrInArray(statement.Resource, "*")

result := {
"documentId": input.document[i].id,
Expand All @@ -37,6 +38,7 @@ CxPolicy[result] { # modules
statement := st[st_index]
common_lib.is_allow_effect(statement)
illegal_action := is_illegal(statement.Action)
common_lib.equalsOrInArray(statement.Resource, "*")

result := {
"documentId": input.document[i].id,
Expand Down Expand Up @@ -74,6 +76,7 @@ prepare_issue_data_source(statement, name, index, is_unique_element) = res {
not is_unique_element
common_lib.is_allow_effect(statement)
illegal_action := is_illegal(statement.actions)
common_lib.equalsOrInArray(statement.resources, "*")

res := {
"sk": sprintf("aws_iam_policy_document[%s].statement[%d].actions", [name, index]),
Expand All @@ -86,6 +89,7 @@ prepare_issue_data_source(statement, name, index, is_unique_element) = res {
is_unique_element
common_lib.is_allow_effect(statement)
illegal_action := is_illegal(statement.actions)
common_lib.equalsOrInArray(statement.resources, "*")

res := {
"sk": sprintf("aws_iam_policy_document[%s].statement.actions", [name]),
Expand Down
31 changes: 31 additions & 0 deletions assets/queries/terraform/aws/iam_policy_allows_for_data_exfiltration/test/negative13.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,31 @@
resource "aws_iam_policy" "positive1" {
name = "positive1_${var.environment}"
description = "Kai Monkey SSM Secrets Policy"

policy = <<EOF
{
"Version": "2012-10-17",
"Statement": [
{
"Sid": "KaiMonkeySSMSecretsPolicyGet",
"Effect": "Allow",
"Action": "secretsmanager:GetSecretValue",
"Resource": "arn:aws:dynamodb:us-east-1:123456789012:table/Users"
},
{
"Sid": "KaiMonkeySSMSecretsPolicyGetDecrypt",
"Effect": "Allow",
"Action": [
"kms:Decrypt",
"ssm:GetParameters",
"ssm:GetParameter",
"s3:GetObject",
"ssm:GetParametersByPath",
"secretsmanager:GetSecretValue"
],
"Resource": "arn:aws:dynamodb:us-east-1:123456789012:table/Users"
}
]
}
EOF
}
2 changes: 1 addition & 1 deletion assets/queries/terraform/aws/iam_policy_allows_for_data_exfiltration/test/positive7.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ module "iam_policy" {
"secretsmanager:GetSecretValue"
],
"Effect": "Allow",
"Resource": "*"
"Resource": ["arn:aws:dynamodb:us-east-1:123456789012:table/Users", "*"]
}
]
}
Expand Down
Loading