Skip to content

Conversation

@gatecat
Copy link
Contributor

@gatecat gatecat commented Jul 10, 2025

No description provided.

@robtaylor robtaylor self-requested a review July 10, 2025 18:21
@gatecat
Copy link
Contributor Author

gatecat commented Jul 11, 2025

That's a very weird CI failure:

 ⠸ Waiting for build to run... running
✔ ✅ Build completed successfully!

Error while executing `silicon submit`: Unexpected error, please report to ChipFlow:
args =
Namespace(log_level=0, log_file=None, command='silicon', action='submit', dry_run=False, wait=True)
traceback =
Traceback (most recent call last):
  File "/home/runner/work/chipflow-examples/chipflow-examples/.venv/lib/python3.13/site-packages/chipflow_lib/cli.py", line 87, in run
    commands[args.command].run_cli(args)
    ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^^^^^^
  File "/home/runner/work/chipflow-examples/chipflow-examples/.venv/lib/python3.13/site-packages/chipflow_lib/steps/silicon.py", line 97, in run_cli
    self.submit(rtlil_path, args)
    ~~~~~~~~~~~^^^^^^^^^^^^^^^^^^
  File "/home/runner/work/chipflow-examples/chipflow-examples/.venv/lib/python3.13/site-packages/chipflow_lib/steps/silicon.py", line 223, in submit
    sp.ok()
    ^^^^^
AttributeError: 'Halo' object has no attribute 'ok'

@gatecat
Copy link
Contributor Author

gatecat commented Jul 11, 2025

I don't know where this line came from or how it ever worked:

https://github.com/ChipFlow/chipflow-lib/blob/02dcf9d2f724adf05e75f5e3dd482e1a67e5954d/chipflow_lib/steps/silicon.py#L223

Can't see any ok function on Halo and it hasn't changed recently either...

@robtaylor
Copy link
Contributor

robtaylor commented Jul 11, 2025 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants