Rename PinSignature to IOSignature #90
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
robtaylor
force-pushed
the
rename-pinsignature
branch
2 times, most recently
from
4c85d12 to
8079ea9
Compare
Contributor
|
This is already getting to be a very large PR, is it possible to split it out? Especially the CI/CD changes from the PinSignature stuff? |
lanserge
approved these changes
May 2, 2025
gatecat
approved these changes
May 2, 2025
Contributor
gatecat
left a comment
gatecat
left a comment
There was a problem hiding this comment.
LGTM on the actual renaming - haven't looked at the CI stuff
Avoids clash with amaranth-soc entity of same name
robtaylor
force-pushed
the
rename-pinsignature
branch
from
8079ea9 to
705762a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoids clash with amaranth-soc entity of same name