- 
                Notifications
    
You must be signed in to change notification settings  - Fork 40
 
Update to EF10 #284
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to EF10 #284
Conversation
Max and Min tests sorted out
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR updates EF10 preview 6 to provide comprehensive support for entity relationship querying and navigation in the EF Core Jet provider, implementing test suites for complex projection scenarios and relationship management.
- Adds extensive test classes for navigation reference and projection queries with tracking and no-tracking variants
 - Implements fixture classes for various relationship testing scenarios including owned entities, JSON types, and table splitting
 - Updates query test implementations to handle new parameter naming conventions and SQL generation patterns
 
Reviewed Changes
Copilot reviewed 105 out of 161 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description | 
|---|---|
| NavigationReferenceProjectionJetTest.cs | Tests navigation reference projections with SQL query validation | 
| NavigationReferenceNoTrackingProjectionJetTest.cs | No-tracking variant of navigation reference projection tests | 
| NavigationProjectionJetTest.cs | Navigation projection tests for various join scenarios | 
| NavigationNoTrackingProjectionJetTest.cs | No-tracking navigation projection tests | 
| ComplexProjectionJetTest.cs | Complex projection scenarios for relationship queries | 
| ComplexNoTrackingProjectionJetTest.cs | No-tracking complex projection tests | 
| Multiple fixture classes | Support infrastructure for relationship testing scenarios | 
| QueryFilterFuncletizationJetTest.cs | Updated parameter naming from @__param_0 to @param format | 
| PrimitiveCollectionsQueryJetTest.cs | Added struct support and updated parameter conventions | 
| PrecompiledSqlPregenerationQueryJetTest.cs | Updated to new parameter naming format | 
| PrecompiledQueryJetTest.cs | Extensive updates including new ExecuteUpdate variants and parameter naming | 
| OwnedQueryJetTest.cs | Optimized EXISTS queries and pagination | 
| OwnedEntityQueryJetTest.cs | Constructor injection pattern and query improvements | 
| OperatorsQueryJetTest.cs | Constructor injection pattern update | 
| OperatorsProceduralJetTest.cs | Constructor injection pattern update | 
Comments suppressed due to low confidence (1)
test/EFCore.Jet.FunctionalTests/Query/PrecompiledQueryJetTest.cs:1862
- The SQL uses SQL Server bracket syntax 
[table].[column]but this is a Jet test file which should use backtick syntaxtable.columnlike the other queries in this file. 
    {
        
          
                ...e.Jet.FunctionalTests/Query/Relationships/Projection/NavigationReferenceProjectionJetTest.cs
              
                Outdated
          
            Show resolved
            Hide resolved
        
              
          
                ...tionalTests/Query/Relationships/Projection/NavigationReferenceNoTrackingProjectionJetTest.cs
              
                Outdated
          
            Show resolved
            Hide resolved
        
              
          
                test/EFCore.Jet.FunctionalTests/Query/Relationships/Projection/NavigationProjectionJetTest.cs
              
                Outdated
          
            Show resolved
            Hide resolved
        
              
          
                ....Jet.FunctionalTests/Query/Relationships/Projection/NavigationNoTrackingProjectionJetTest.cs
              
                Outdated
          
            Show resolved
            Hide resolved
        
      …/NavigationReferenceProjectionJetTest.cs Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…/NavigationReferenceNoTrackingProjectionJetTest.cs Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…/NavigationProjectionJetTest.cs Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…/NavigationNoTrackingProjectionJetTest.cs Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Updates to base on EF10 preview 6