Skip to content

Conversation

@sajagana
Copy link
Collaborator

Note:

Added modules to create and update AAA Domains, Roles and Custom Privileges on Cisco ACI fabrics.

@sajagana sajagana requested a review from xinyuezhao January 20, 2022 15:27
@sajagana sajagana added the look again Ready for the review, changes are updated label Jan 21, 2022
xinyuezhao
xinyuezhao previously approved these changes Jan 21, 2022
Copy link
Contributor

@xinyuezhao xinyuezhao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sajagana sajagana added approved Ready to merge and removed look again Ready for the review, changes are updated labels Jan 21, 2022
anvitha-jain
anvitha-jain previously approved these changes Feb 17, 2022
@lhercot lhercot dismissed stale reviews from anvitha-jain and xinyuezhao via 1eae215 October 21, 2022 05:03
@lhercot lhercot force-pushed the AAA_Roles_Domains_Custom_Privileges branch from 2a5e599 to 1eae215 Compare October 21, 2022 05:03
lhercot
lhercot previously approved these changes Oct 21, 2022
Copy link
Member

@lhercot lhercot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

… PR comments and test fixes to skip tasks not supported before ACI v5.0
@lhercot lhercot force-pushed the AAA_Roles_Domains_Custom_Privileges branch from 1eae215 to b99ccc8 Compare October 21, 2022 05:25
Copy link
Member

@lhercot lhercot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lhercot lhercot merged commit f283ad0 into CiscoDevNet:master Oct 21, 2022
@sajagana sajagana deleted the AAA_Roles_Domains_Custom_Privileges branch April 25, 2023 03:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Ready to merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants