-
Notifications
You must be signed in to change notification settings - Fork 107
Added aaa_domain, aaa_role and custom_privilege modules and test files #226
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
lhercot
merged 3 commits into
CiscoDevNet:master
from
sajagana:AAA_Roles_Domains_Custom_Privileges
Oct 21, 2022
Merged
Added aaa_domain, aaa_role and custom_privilege modules and test files #226
lhercot
merged 3 commits into
CiscoDevNet:master
from
sajagana:AAA_Roles_Domains_Custom_Privileges
Oct 21, 2022
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xinyuezhao
suggested changes
Jan 19, 2022
xinyuezhao
previously approved these changes
Jan 21, 2022
Contributor
xinyuezhao
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
anvitha-jain
previously approved these changes
Feb 17, 2022
lhercot
requested changes
Oct 17, 2022
2a5e599 to
1eae215
Compare
lhercot
previously approved these changes
Oct 21, 2022
Member
lhercot
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
… PR comments and test fixes to skip tasks not supported before ACI v5.0
1eae215 to
b99ccc8
Compare
lhercot
approved these changes
Oct 21, 2022
Member
lhercot
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note:
Added modules to create and update AAA Domains, Roles and Custom Privileges on Cisco ACI fabrics.