-
Notifications
You must be signed in to change notification settings - Fork 107
add action_groups for module_defaults #316
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
rafmuller
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested this and works as advertised. This solves a big problem for us in large Ansible automation executions
|
Thank you for your approval! |
|
One thing I noticed is that in this PR you have a non-standard module on the list aci_bulk_static_binding_to_epg. Probably needs cleanup before merge. |
|
@rafmuller The following modules including
Therefore, these modules should be included in the list in the next release. |
|
Added the following modules that were added after submitting this PR.
|
|
@akira6592 is there a way to just have a wildcard? This looks like it will be a pain to manage this list. |
|
@akira6592 Have you seen my question above? |
|
@lhercot Sorry for the delay in replying. Unfortunately there does not seem to be a way to specify a module with wildcards. Other collections (e.g., If there is a workaround, it would be to add an explanation in the |
0575b79 to
6ac0a37
Compare
lhercot
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
Thanks for the contribution! To avoid having to manually modify the list, I have added a small function to our release script (which also build our changelog for new releases) which compile the list and output it in the meta/runtime.yml file. You can see more details here: ciscoecosystem/release_script@4f693d3 |
|
Thank you for merging and adding the process to generate |
|
FYI, we have decided to rename the group to all so it will be |
add action_groups in
meta/runtime.yml.This allows module_defaults group feature.
https://docs.ansible.com/ansible/latest/user_guide/playbooks_module_defaults.html#module-defaults-groups
It becomes able to specify common options such as host username and password without specifying per tasks or using environment variables.