-
Notifications
You must be signed in to change notification settings - Fork 107
Added Node Profile BGP Peer and Route Control Profile functionalities #340
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
lhercot
merged 4 commits into
CiscoDevNet:master
from
sajagana:312_bgp_peer_to_rctrl_profile
Jan 18, 2023
Merged
Added Node Profile BGP Peer and Route Control Profile functionalities #340
lhercot
merged 4 commits into
CiscoDevNet:master
from
sajagana:312_bgp_peer_to_rctrl_profile
Jan 18, 2023
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anvitha-jain
requested changes
Nov 15, 2022
akinross
reviewed
Nov 16, 2022
akinross
previously approved these changes
Nov 17, 2022
Collaborator
akinross
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
anvitha-jain
previously approved these changes
Nov 21, 2022
Collaborator
anvitha-jain
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
lhercot
requested changes
Jan 12, 2023
368fb13 to
1c0bab8
Compare
lhercot
previously approved these changes
Jan 17, 2023
Member
lhercot
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…and add condition on bgpRsPeerToProfile child class query in aci_l3out_bgp_peer
lhercot
approved these changes
Jan 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note:
Added BGP Peer to the Node Profile level and also added the functionality to bind Route Control Profile to BGP Peer.