Skip to content

Conversation

@DanielMuller-TN
Copy link
Contributor

Forced unicode encoding for lxml XML fragment validation output to resolve certification authentication request signing TypeError failures.

Relates to bug #339

akinross
akinross previously approved these changes Mar 8, 2023
Copy link
Collaborator

@akinross akinross left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ran test locally successful with rebased code

@lhercot
Copy link
Member

lhercot commented Mar 8, 2023

This is missing a specific test case in the aci_rest test cases that uses XML + Certificate Authentication so we don't reintroduce this issue in the past.

DanielMuller-TN and others added 2 commits March 15, 2023 09:45
@codecov
Copy link

codecov bot commented Mar 15, 2023

Codecov Report

Patch coverage has no change and project coverage change: -53.92 ⚠️

Comparison is base (352501c) 90.20% compared to head (73ef8fc) 36.28%.

❗ Current head 73ef8fc differs from pull request most recent head d7028a3. Consider uploading reports for the commit d7028a3 to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##           master     #341       +/-   ##
===========================================
- Coverage   90.20%   36.28%   -53.92%     
===========================================
  Files         161      161               
  Lines        7135     7135               
  Branches     1039     1039               
===========================================
- Hits         6436     2589     -3847     
- Misses        593     4546     +3953     
+ Partials      106        0      -106     
Flag Coverage Δ
integration ?
sanity 36.28% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
plugins/modules/aci_rest.py 27.61% <0.00%> (-53.74%) ⬇️

... and 140 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

lhercot
lhercot previously approved these changes Mar 15, 2023
Copy link
Member

@lhercot lhercot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Co-authored-by: Lionel Hercot <lionel.hercot@gmail.com>
Copy link
Member

@lhercot lhercot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lhercot lhercot merged commit 3361ad3 into CiscoDevNet:master Mar 15, 2023
@lhercot
Copy link
Member

lhercot commented Mar 15, 2023

Thanks for the contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

aci_rest module fails with an error when using certificate authentication and a xml fragment payload

3 participants