-
Notifications
You must be signed in to change notification settings - Fork 107
Forced unicode encoding for lxml XML fragment validation output #341
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ran test locally successful with rebased code
|
This is missing a specific test case in the aci_rest test cases that uses XML + Certificate Authentication so we don't reintroduce this issue in the past. |
to resolve certification authentication request signing TypeError failures.
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## master #341 +/- ##
===========================================
- Coverage 90.20% 36.28% -53.92%
===========================================
Files 161 161
Lines 7135 7135
Branches 1039 1039
===========================================
- Hits 6436 2589 -3847
- Misses 593 4546 +3953
+ Partials 106 0 -106
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 140 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
lhercot
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Co-authored-by: Lionel Hercot <lionel.hercot@gmail.com>
lhercot
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
Thanks for the contribution! |
Forced unicode encoding for lxml XML fragment validation output to resolve certification authentication request signing TypeError failures.
Relates to bug #339