Skip to content

[minor_change] source span sources support #344

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jan 13, 2023
Merged

[minor_change] source span sources support #344

merged 3 commits into from
Jan 13, 2023

Conversation

@akinross
Copy link
Collaborator

@akinross akinross commented Nov 22, 2022

fix for #336

@akinross akinross linked an issue Nov 22, 2022 that may be closed by this pull request
In the "cisco.aci.aci_tenant_span_src_group" you cannot create the SPAN source. #336
Closed
sajagana
sajagana reviewed Dec 8, 2022
View reviewed changes
Copy link
Collaborator

@sajagana sajagana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Try to add detailed names for the tasks; if possible, use the object name and title of that object as per the UI for the task name.

anvitha-jain
anvitha-jain previously approved these changes Dec 8, 2022
View reviewed changes
Copy link
Collaborator

@anvitha-jain anvitha-jain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@anvitha-jain anvitha-jain self-requested a review December 13, 2022 16:53
anvitha-jain
anvitha-jain previously approved these changes Dec 13, 2022
View reviewed changes
Copy link
Collaborator

@anvitha-jain anvitha-jain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

lhercot
lhercot requested changes Jan 12, 2023
View reviewed changes
lhercot
lhercot requested changes Jan 13, 2023
View reviewed changes
lhercot
lhercot approved these changes Jan 13, 2023
View reviewed changes
Copy link
Member

@lhercot lhercot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lhercot lhercot merged commit a0683b2 into CiscoDevNet:master Jan 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sajagana sajagana sajagana left review comments

@lhercot lhercot lhercot approved these changes

@anvitha-jain anvitha-jain anvitha-jain left review comments

@shrsr shrsr Awaiting requested review from shrsr shrsr is a code owner

@xinyuezhao xinyuezhao Awaiting requested review from xinyuezhao

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

In the "cisco.aci.aci_tenant_span_src_group" you cannot create the SPAN source.

4 participants

@akinross @lhercot @anvitha-jain @sajagana