Skip to content

Conversation

@timcragg
Copy link
Contributor

This PR adds a module and integration test for the configExportP object. The existing aci_config_snapshot module can be used to create configExportP objects, but can only query or delete snapshot objects rather than the export policy. This new module is able to query and delete configExportP objects, and can also configure the child configRsExportScheduler and configRsRemotePath objects.

@codecov
Copy link

codecov bot commented Feb 17, 2023

Codecov Report

Patch coverage: 32.38% and project coverage change: -55.54 ⚠️

Comparison is base (77d4a11) 91.76% compared to head (b3dcfdc) 36.22%.

❗ Current head b3dcfdc differs from pull request most recent head 6eb5de9. Consider uploading reports for the commit 6eb5de9 to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##           master     #380       +/-   ##
===========================================
- Coverage   91.76%   36.22%   -55.54%     
===========================================
  Files         141      163       +22     
  Lines        6534     7240      +706     
  Branches      966     1055       +89     
===========================================
- Hits         5996     2623     -3373     
- Misses        292     4617     +4325     
+ Partials      246        0      -246     
Flag Coverage Δ
integration ?
sanity 36.22% <32.38%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
plugins/modules/aci_interface_config.py 28.78% <28.78%> (ø)
plugins/modules/aci_config_export_policy.py 38.46% <38.46%> (ø)

... and 161 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Collaborator

@akinross akinross left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see comments

@timcragg timcragg requested review from akinross and removed request for anvitha-jain, sajagana and shrsr March 16, 2023 15:02
@akinross akinross requested review from lhercot, sajagana and shrsr March 16, 2023 16:01
Copy link
Collaborator

@akinross akinross left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@akinross akinross left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could you please add that for scheduler and export_destination functionality?

Copy link
Collaborator

@akinross akinross left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could you please add that for scheduler and export_destination functionality?

@timcragg timcragg requested review from akinross and removed request for lhercot, sajagana and shrsr March 17, 2023 11:06
Copy link
Collaborator

@akinross akinross left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see comment

@timcragg timcragg requested a review from akinross April 3, 2023 12:57
Copy link
Collaborator

@akinross akinross left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@anvitha-jain anvitha-jain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@anvitha-jain anvitha-jain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@lhercot lhercot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lhercot lhercot merged commit 39708ce into CiscoDevNet:master Apr 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants