Feat/igmp intf policy #381
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #381 +/- ##
===========================================
- Coverage 91.76% 36.17% -55.60%
===========================================
Files 141 163 +22
Lines 6534 7254 +720
Branches 966 1057 +91
===========================================
- Hits 5996 2624 -3372
- Misses 292 4630 +4338
+ Partials 246 0 -246
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 161 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
akinross
reviewed
Mar 8, 2023
akinross
reviewed
Mar 8, 2023
akinross
reviewed
Mar 8, 2023
akinross
reviewed
Mar 8, 2023
akinross
reviewed
Mar 8, 2023
akinross
reviewed
Mar 8, 2023
akinross
reviewed
Mar 8, 2023
akinross
reviewed
Mar 8, 2023
akinross
reviewed
Mar 9, 2023
akinross
reviewed
Mar 16, 2023
akinross
requested changes
Mar 16, 2023
Collaborator
akinross
left a comment
akinross
left a comment
There was a problem hiding this comment.
can you add test case for report_link_local_groups?
…ci into feat/igmp_intf_policy
timcragg
requested review from
akinross
and removed request for
anvitha-jain,
sajagana and
shrsr
akinross
reviewed
Mar 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a module and integration tests for the igmpIfPol object