-
Notifications
You must be signed in to change notification settings - Fork 107
Add spanning tree interface policy module and associated tests #387
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
tests/integration/targets/aci_interface_policy_spanning_tree/tasks/main.yml
Show resolved
Hide resolved
tests/integration/targets/aci_interface_policy_spanning_tree/tasks/main.yml
Outdated
Show resolved
Hide resolved
akinross
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
see inline comments
|
@akinross just need to add the examples. I commented on the conversations, but left them unresolved so that you or another reviewer can verify before closing. Let me know if you would prefer I resolve them. |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #387 +/- ##
==========================================
- Coverage 90.14% 90.12% -0.03%
==========================================
Files 160 161 +1
Lines 7095 7131 +36
Branches 1034 1039 +5
==========================================
+ Hits 6396 6427 +31
- Misses 593 596 +3
- Partials 106 108 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
akinross
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
lhercot
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
Thanks for the contribution! |
No description provided.