Skip to content

Conversation

@netgirard
Copy link
Contributor

No description provided.

Copy link
Collaborator

@akinross akinross left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see inline comments

@netgirard
Copy link
Contributor Author

@akinross just need to add the examples. I commented on the conversations, but left them unresolved so that you or another reviewer can verify before closing. Let me know if you would prefer I resolve them.

@netgirard netgirard requested review from akinross and removed request for anvitha-jain, sajagana and shrsr March 8, 2023 14:55
@codecov
Copy link

codecov bot commented Mar 8, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.03 ⚠️

Comparison is base (ad147dd) 90.14% compared to head (4813dc8) 90.12%.

❗ Current head 4813dc8 differs from pull request most recent head af67efd. Consider uploading reports for the commit af67efd to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #387      +/-   ##
==========================================
- Coverage   90.14%   90.12%   -0.03%     
==========================================
  Files         160      161       +1     
  Lines        7095     7131      +36     
  Branches     1034     1039       +5     
==========================================
+ Hits         6396     6427      +31     
- Misses        593      596       +3     
- Partials      106      108       +2     
Flag Coverage Δ
integration 91.73% <97.22%> (-0.05%) ⬇️
sanity 36.25% <44.44%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...gins/modules/aci_interface_policy_spanning_tree.py 100.00% <100.00%> (ø)
plugins/modules/aci_contract_subject_to_filter.py 98.24% <0.00%> (-1.76%) ⬇️
plugins/module_utils/aci.py 69.38% <0.00%> (-0.50%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Collaborator

@akinross akinross left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@lhercot lhercot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lhercot lhercot merged commit 352501c into CiscoDevNet:master Mar 9, 2023
@lhercot
Copy link
Member

lhercot commented Mar 9, 2023

Thanks for the contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants