Skip to content

Conversation

@akinross
Copy link
Collaborator

@akinross akinross commented Apr 3, 2023

No description provided.

@akinross akinross self-assigned this Apr 3, 2023
@codecov
Copy link

codecov bot commented Apr 3, 2023

Codecov Report

Patch coverage: 36.36% and no project coverage change.

Comparison is base (e3fc080) 36.21% compared to head (48866ef) 36.21%.

❗ Current head 48866ef differs from pull request most recent head 14d4cdd. Consider uploading reports for the commit 14d4cdd to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #405   +/-   ##
=======================================
  Coverage   36.21%   36.21%           
=======================================
  Files         162      163    +1     
  Lines        7201     7256   +55     
  Branches     1050     1061   +11     
=======================================
+ Hits         2608     2628   +20     
- Misses       4593     4628   +35     
Flag Coverage Δ
sanity 36.21% <36.36%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
plugins/modules/aci_access_span_dst_group.py 36.36% <36.36%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@akinross akinross linked an issue Apr 3, 2023 that may be closed by this pull request
anvitha-jain
anvitha-jain previously approved these changes Apr 3, 2023
Copy link
Collaborator

@anvitha-jain anvitha-jain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@sajagana sajagana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@akinross akinross requested a review from sajagana April 5, 2023 09:49
Copy link
Collaborator

@shrsr shrsr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@lhercot lhercot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@sajagana sajagana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@lhercot lhercot merged commit 824db28 into CiscoDevNet:master Apr 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants