-
Notifications
You must be signed in to change notification settings - Fork 107
Added IP Dataplane attribute to the subnet and vrf module #413
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added IP Dataplane attribute to the subnet and vrf module #413
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #413 +/- ##
===========================================
- Coverage 90.36% 36.29% -54.07%
===========================================
Files 165 168 +3
Lines 7348 7417 +69
Branches 1073 1079 +6
===========================================
- Hits 6640 2692 -3948
- Misses 599 4725 +4126
+ Partials 109 0 -109
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 142 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
akinross
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
anvitha-jain
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
lhercot
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Note:
Added IP Dataplane attribute to the aci_bd_subnet and aci_vrf module