Skip to content

Conversation

@sajagana
Copy link
Collaborator

Note:

Added IP Dataplane attribute to the aci_bd_subnet and aci_vrf module

@sajagana sajagana marked this pull request as draft April 18, 2023 14:22
@sajagana sajagana marked this pull request as ready for review April 18, 2023 14:43
@sajagana sajagana linked an issue Apr 18, 2023 that may be closed by this pull request
@codecov
Copy link

codecov bot commented Apr 18, 2023

Codecov Report

Patch coverage: 49.29% and project coverage change: -54.07 ⚠️

Comparison is base (824db28) 90.36% compared to head (591601e) 36.29%.

❗ Current head 591601e differs from pull request most recent head 7596b48. Consider uploading reports for the commit 7596b48 to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##           master     #413       +/-   ##
===========================================
- Coverage   90.36%   36.29%   -54.07%     
===========================================
  Files         165      168        +3     
  Lines        7348     7417       +69     
  Branches     1073     1079        +6     
===========================================
- Hits         6640     2692     -3948     
- Misses        599     4725     +4126     
+ Partials      109        0      -109     
Flag Coverage Δ
integration ?
sanity 36.29% <49.29%> (+0.10%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
plugins/modules/aci_bd_subnet.py 30.76% <0.00%> (-65.31%) ⬇️
plugins/modules/aci_vrf.py 43.58% <0.00%> (-56.42%) ⬇️
...gins/modules/aci_access_span_filter_group_entry.py 44.73% <44.73%> (ø)
plugins/modules/aci_access_span_filter_group.py 53.57% <53.57%> (ø)
plugins/module_utils/constants.py 100.00% <100.00%> (ø)
plugins/modules/aci_filter_entry.py 35.38% <100.00%> (-55.53%) ⬇️

... and 142 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

akinross
akinross previously approved these changes Apr 18, 2023
Copy link
Collaborator

@akinross akinross left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

anvitha-jain
anvitha-jain previously approved these changes Apr 18, 2023
Copy link
Collaborator

@anvitha-jain anvitha-jain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sajagana sajagana dismissed stale reviews from anvitha-jain and akinross via 7596b48 April 19, 2023 12:19
Copy link
Member

@lhercot lhercot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lhercot lhercot merged commit 70df019 into CiscoDevNet:master Apr 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

configure ip dataplane learning at BD subnet level

4 participants