Skip to content

Conversation

@sajagana
Copy link
Collaborator

Note:

Added bgpLocalAsnP child object to aci_l3out_bgp_peer module to configure the local Autonomous System Number and Configuration.

@sajagana sajagana requested a review from akinross April 24, 2023 15:32
@codecov
Copy link

codecov bot commented Apr 24, 2023

Codecov Report

Patch coverage: 26.78% and project coverage change: -54.24 ⚠️

Comparison is base (70df019) 90.45% compared to head (6572606) 36.22%.

❗ Current head 6572606 differs from pull request most recent head 27b7f0f. Consider uploading reports for the commit 27b7f0f to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##           master     #416       +/-   ##
===========================================
- Coverage   90.45%   36.22%   -54.24%     
===========================================
  Files         168      169        +1     
  Lines        7417     7473       +56     
  Branches     1079     1089       +10     
===========================================
- Hits         6709     2707     -4002     
- Misses        599     4766     +4167     
+ Partials      109        0      -109     
Flag Coverage Δ
integration ?
sanity 36.22% <26.78%> (-0.08%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
plugins/modules/aci_l3out_bgp_peer.py 17.85% <0.00%> (-80.90%) ⬇️
plugins/modules/aci_file_remote_path.py 28.84% <28.84%> (ø)

... and 146 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Collaborator

@akinross akinross left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@shrsr shrsr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@anvitha-jain anvitha-jain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@lhercot lhercot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lhercot lhercot merged commit 6a27bc0 into CiscoDevNet:master Apr 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

BGP local AS and Local AS Config missing from cisco.aci.aci_l3out_bgp_peer module

5 participants