Skip to content

[minor_change] Add aci_epg_subnet module #424

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 4, 2023
Merged

[minor_change] Add aci_epg_subnet module #424

merged 2 commits into from
May 4, 2023

Conversation

@gmicol
Copy link
Collaborator

@gmicol gmicol commented Apr 26, 2023

close #350

@gmicol gmicol force-pushed the 350-epg_subnet branch 2 times, most recently from 97147c2 to f67104c Compare April 26, 2023 16:59
@codecov
Copy link

codecov bot commented Apr 26, 2023 •
edited
Loading

Codecov Report

Patch coverage: 31.48% and project coverage change: -0.04 ⚠️

Comparison is base (f68a7eb) 36.07% compared to head (4656377) 36.03%.

❗ Current head 4656377 differs from pull request most recent head 8d409c0. Consider uploading reports for the commit 8d409c0 to get more accurate results

Additional details and impacted files 
@@            Coverage Diff             @@
##           master     #424      +/-   ##
==========================================
- Coverage   36.07%   36.03%   -0.04%     
==========================================
  Files         169      170       +1     
  Lines        7499     7553      +54     
  Branches     1100     1108       +8     
==========================================
+ Hits         2705     2722      +17     
- Misses       4794     4831      +37
Flag Coverage Δ
sanity 36.03% <31.48%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
plugins/modules/aci_epg_subnet.py 30.18% <30.18%> (ø)
plugins/module_utils/constants.py 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

shrsr
shrsr previously approved these changes Apr 26, 2023
View reviewed changes
Copy link
Collaborator

@shrsr shrsr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

sajagana
sajagana requested changes Apr 27, 2023
View reviewed changes
@gmicol gmicol force-pushed the 350-epg_subnet branch 2 times, most recently from 4bb0eaa to aaf25f3 Compare April 27, 2023 16:14
@gmicol gmicol requested review from sajagana and shrsr April 27, 2023 16:17
anvitha-jain
anvitha-jain requested changes Apr 27, 2023
View reviewed changes
@gmicol gmicol requested a review from anvitha-jain April 27, 2023 19:41
sajagana
sajagana requested changes Apr 28, 2023
View reviewed changes
shrsr
shrsr previously approved these changes May 1, 2023
View reviewed changes
Copy link
Collaborator

@shrsr shrsr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@anvitha-jain anvitha-jain requested a review from sajagana May 1, 2023 17:36
anvitha-jain
anvitha-jain previously approved these changes May 1, 2023
View reviewed changes
Copy link
Collaborator

@anvitha-jain anvitha-jain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

sajagana
sajagana previously approved these changes May 2, 2023
View reviewed changes
Copy link
Collaborator

@sajagana sajagana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

lhercot
lhercot previously approved these changes May 4, 2023
View reviewed changes
Copy link
Member

@lhercot lhercot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

gmicol and others added 2 commits May 4, 2023 10:50
@gmicol @lhercot
[minor_change] Add aci_epg_subnet module
5c5c91e
@gmicol @sajagana @lhercot
Update plugins/modules/aci_epg_subnet.py
8d409c0 
Co-authored-by: Sabari Jaganathan <93724860+sajagana@users.noreply.github.com>
@lhercot lhercot dismissed stale reviews from sajagana, anvitha-jain, shrsr, and themself via 8d409c0 May 4, 2023 08:51
lhercot
lhercot approved these changes May 4, 2023
View reviewed changes
Copy link
Member

@lhercot lhercot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lhercot lhercot merged commit 4bf91f9 into CiscoDevNet:master May 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lhercot lhercot lhercot approved these changes

@shrsr shrsr shrsr left review comments

@anvitha-jain anvitha-jain anvitha-jain left review comments

@sajagana sajagana sajagana left review comments

@akinross akinross Awaiting requested review from akinross akinross is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

ip dataplane learning enable/disable at epg subnet level

5 participants

@gmicol @lhercot @shrsr @anvitha-jain @sajagana