Skip to content

Conversation

@sajagana
Copy link
Collaborator

Note:

Added the TCP session rules and match fragment to the aci_filter_entry module also included the Source Port of the TCP/UDP protocol.

@codecov
Copy link

codecov bot commented Apr 27, 2023

Codecov Report

Patch coverage: 12.00% and project coverage change: -54.44 ⚠️

Comparison is base (fc38459) 90.50% compared to head (2de7051) 36.07%.

❗ Current head 2de7051 differs from pull request most recent head bcc676d. Consider uploading reports for the commit bcc676d to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##           master     #426       +/-   ##
===========================================
- Coverage   90.50%   36.07%   -54.44%     
===========================================
  Files         169      169               
  Lines        7469     7499       +30     
  Branches     1088     1100       +12     
===========================================
- Hits         6760     2705     -4055     
- Misses        599     4794     +4195     
+ Partials      110        0      -110     
Flag Coverage Δ
integration ?
sanity 36.07% <12.00%> (-0.18%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
plugins/modules/aci_l3out_bgp_peer.py 17.85% <0.00%> (-80.90%) ⬇️
plugins/modules/aci_filter_entry.py 18.60% <2.43%> (-72.17%) ⬇️
plugins/module_utils/constants.py 100.00% <100.00%> (ø)

... and 146 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Collaborator

@gmicol gmicol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@shrsr shrsr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@anvitha-jain anvitha-jain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@lhercot lhercot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lhercot lhercot merged commit f68a7eb into CiscoDevNet:master May 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add support for tcp session rules and match fragment in aci_filter_entry Add Source Port/Range to cisco.aci.aci_filter_entry

5 participants