Skip to content

Conversation

@abrahammughal
Copy link
Contributor

Closes #442

@abrahammughal abrahammughal changed the title Issue 442 Add aci_vrf_leak_internal_subnet module Jun 19, 2023
@codecov
Copy link

codecov bot commented Jun 19, 2023

Codecov Report

Patch coverage: 97.84% and project coverage change: +0.34 🎉

Comparison is base (5ea28e6) 91.16% compared to head (1d072bc) 91.50%.

❗ Current head 1d072bc differs from pull request most recent head 3b44897. Consider uploading reports for the commit 3b44897 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #449      +/-   ##
==========================================
+ Coverage   91.16%   91.50%   +0.33%     
==========================================
  Files         178      179       +1     
  Lines        7925     7995      +70     
  Branches     1173     1184      +11     
==========================================
+ Hits         7225     7316      +91     
+ Misses        594      584      -10     
+ Partials      106       95      -11     
Flag Coverage Δ
integration 92.80% <96.77%> (+0.34%) ⬆️
sanity 35.95% <24.73%> (-0.07%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
plugins/modules/aci_config_rollback.py 87.50% <ø> (ø)
plugins/modules/aci_config_snapshot.py 100.00% <ø> (ø)
plugins/module_utils/aci.py 71.51% <86.66%> (+1.21%) ⬆️
plugins/module_utils/constants.py 100.00% <100.00%> (ø)
plugins/modules/aci_l3out.py 100.00% <100.00%> (+26.22%) ⬆️
...ins/modules/aci_l3out_logical_interface_profile.py 100.00% <100.00%> (ø)
plugins/modules/aci_vrf_leak_internal_subnet.py 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@abrahammughal abrahammughal marked this pull request as ready for review June 27, 2023 15:44
@lhercot lhercot requested review from akinross and anvitha-jain June 27, 2023 17:02
@abrahammughal abrahammughal requested review from lhercot and shrsr July 7, 2023 17:32
@abrahammughal abrahammughal requested a review from shrsr July 8, 2023 01:37
shrsr
shrsr previously approved these changes Jul 10, 2023
Copy link
Collaborator

@shrsr shrsr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

gmicol
gmicol previously approved these changes Jul 12, 2023
Copy link
Collaborator

@gmicol gmicol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@abrahammughal abrahammughal dismissed stale reviews from gmicol and shrsr via caa1511 July 13, 2023 16:12
shrsr
shrsr previously approved these changes Jul 13, 2023
Copy link
Collaborator

@shrsr shrsr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@gmicol gmicol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@shrsr shrsr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@lhercot lhercot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lhercot lhercot merged commit 6b54766 into CiscoDevNet:master Jul 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add support for EPG/BD subnets under VRF for route leaking

6 participants