Addition of l3out Floating SVI module and its child modules #478

shrsr · 2023-09-21T01:38:38Z

No description provided.

codecov · 2023-09-26T05:32:56Z

Codecov Report

Attention: 719 lines in your changes are missing coverage. Please review.

Comparison is base (4cee5c5) 96.62% compared to head (03553da) 35.18%.
Report is 47 commits behind head on master.

❗ Current head 03553da differs from pull request most recent head 870fb1c. Consider uploading reports for the commit 870fb1c to get more accurate results

Files	Patch %	Lines
plugins/modules/aci_vrf_multicast.py	17.11%	92 Missing ⚠️
plugins/modules/aci_access_switch_policy_group.py	17.00%	83 Missing ⚠️
plugins/module_utils/aci.py	1.69%	58 Missing ⚠️
plugins/modules/aci_l3out_floating_svi_path.py	23.43%	49 Missing ⚠️
plugins/modules/aci_l3out_floating_svi.py	27.27%	40 Missing ⚠️
plugins/modules/aci_fabric_pod_selector.py	33.92%	37 Missing ⚠️
plugins/modules/aci_route_control_context.py	33.33%	32 Missing ⚠️
...odules/aci_l3out_floating_svi_path_secondary_ip.py	36.58%	26 Missing ⚠️
plugins/modules/aci_fabric_wide_settings.py	42.50%	23 Missing ⚠️
plugins/modules/aci_l3out_bgp_protocol_profile.py	41.02%	23 Missing ⚠️
... and 17 more

Additional details and impacted files

@@             Coverage Diff             @@
##           master     #478       +/-   ##
===========================================
- Coverage   96.62%   35.18%   -61.44%     
===========================================
  Files         183      206       +23     
  Lines        8475     9574     +1099     
  Branches     1265     1432      +167     
===========================================
- Hits         8189     3369     -4820     
- Misses        214     6205     +5991     
+ Partials       72        0       -72

Flag	Coverage Δ
integration	`?`
sanity	`35.18% <34.87%> (+0.01%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

…dules

… module

…tect the presence of children of a child

…to add secondary ips

…unterparts

… to accommodate creation of a class deeper in the aci object hierarchy

plugins/modules/aci_l3out_floating_svi.py

plugins/modules/aci_l3out_floating_svi_path_secondary_ip.py

plugins/modules/aci_l3out_floating_svi_secondary_ip.py

…vi' module and its child modules

plugins/modules/aci_l3out_floating_svi.py

plugins/modules/aci_l3out_floating_svi_path.py

plugins/modules/aci_l3out_floating_svi_secondary_ip.py

plugins/modules/aci_l3out_floating_svi_path_secondary_ip.py

plugins/modules/aci_l3out_floating_svi_secondary_ip.py

shrsr · 2023-10-04T11:20:40Z

Replies-

Addition of l3out Floating SVI module and its child modules #478 (comment)
-> Not everywhere. See: https://github.com/CiscoDevNet/ansible-aci/blob/0dcf72cdf86875ec818e1790797274175d2786aa/plugins/modules/aci_l3out_logical_interface_profile.py
However, it might be useful and easier for the user to have more info. I'll go ahead and add those.
Addition of l3out Floating SVI module and its child modules #478 (comment)
-> I know its been implemented in other modules. However, in this case it would be much easier for customers/users to find the modules when they have appropriate names. In my case the tree structure of the modules looks like this.

L3out
logical_node_profile
logical_interface_profile
floating_svi
- floating_svi_secondary_ip
floating_svi_path
- floating_svi_path_secondary_ip

…_svi' modules

tests/integration/targets/aci_l3out_floating_svi_secondary_ip/tasks/main.yml

…dary_ip' for a few tasks

akinross

LGTM

plugins/modules/aci_l3out_floating_svi.py

plugins/modules/aci_l3out_floating_svi_path.py

plugins/modules/aci_l3out_floating_svi_path_secondary_ip.py

plugins/modules/aci_l3out_floating_svi_secondary_ip.py

tests/integration/targets/aci_l3out_floating_svi/tasks/main.yml

sajagana

LGTM!

gmicol

LGTM!!

plugins/modules/aci_l3out_floating_svi_path.py

…n the 'floating_svi_modules'

akinross

LGTM

…t floating modules'

tests/integration/targets/aci_l3out_floating_svi/tasks/main.yml

…incorporate all versions of apic

tests/integration/targets/aci_l3out_floating_svi/tasks/main.yml

akinross

LGTM

gmicol

LGTM!

lhercot

LGTM

gmicol · 2023-12-21T15:44:36Z

is part of issue #126

shrsr self-assigned this Sep 21, 2023

shrsr added 8 commits September 30, 2023 10:08

[minor_change] Addition of l3out Floating SVI module and its child mo…

617115a

…dules

[ignore] Addition of child to a child class in the 'aci_floating_svi'…

1730144

… module

[ignore] Addition of 'l3out_floating_svi_path_attributes' module

fa75f30

[ignore] Change in payload function of 'aci.py' in module_utils to de…

5eb1f04

…tect the presence of children of a child

[ignore] Addition of 'aci_l3out_floating_svi_path_attributes' module …

28bad78

…to add secondary ips

[ignore] Addition of a test file for the module 'l3out_floating_svi'

e8bf1ff

[ignore] Addition of test files for 'floating_svi' modules and its co…

05acd43

…unterparts

[ignore] Addition of sub class 6 function to 'aci.py' of module_utils…

79c2824

… to accommodate creation of a class deeper in the aci object hierarchy

shrsr force-pushed the floating branch from 5dc18ee to 79c2824 Compare October 2, 2023 20:54

shrsr requested review from akinross, anvitha-jain, gmicol, lhercot and sajagana October 2, 2023 21:04

akinross requested changes Oct 3, 2023

View reviewed changes

[ignore] Modified docs to represent relations between the 'floating_s…

2b5ce7f

…vi' module and its child modules

shrsr requested a review from akinross October 3, 2023 21:34

akinross requested changes Oct 4, 2023

View reviewed changes

[ignore] Modified docs to exclude un-used parameters in the 'floating…

72d1111

…_svi' modules

shrsr requested a review from akinross October 4, 2023 19:02

akinross reviewed Oct 5, 2023

View reviewed changes

tests/integration/targets/aci_l3out_floating_svi_secondary_ip/tasks/main.yml Show resolved Hide resolved

[ignore] Modified test file to include anchors in 'floating_svi_secon…

8264801

…dary_ip' for a few tasks

shrsr requested a review from akinross October 5, 2023 13:04

akinross previously approved these changes Oct 5, 2023

View reviewed changes

anvitha-jain requested changes Oct 10, 2023

View reviewed changes

[ignore] Added a field for author in the modules of 'floating_svi'

3e401f6

shrsr dismissed akinross’s stale review via 3e401f6 October 11, 2023 17:09

sajagana previously approved these changes Oct 24, 2023

View reviewed changes

gmicol previously approved these changes Oct 25, 2023

View reviewed changes

lhercot requested changes Oct 31, 2023

View reviewed changes

plugins/modules/aci_l3out_floating_svi_path.py Outdated Show resolved Hide resolved

plugins/modules/aci_l3out_floating_svi_path.py Outdated Show resolved Hide resolved

[ignore] Addition of code to incorporate different versions of apic i…

8f78614

…n the 'floating_svi_modules'

shrsr dismissed stale reviews from gmicol, sajagana, and akinross via 8f78614 November 3, 2023 04:55

shrsr requested review from akinross, gmicol, lhercot and sajagana November 3, 2023 04:56

akinross previously approved these changes Nov 3, 2023

View reviewed changes

[ignore] Addition of notes to attributes in the docs section of 'l3ou…

26b5141

…t floating modules'

shrsr dismissed akinross’s stale review via 26b5141 November 3, 2023 17:37

shrsr requested a review from akinross November 3, 2023 17:38

akinross requested changes Nov 3, 2023

View reviewed changes

tests/integration/targets/aci_l3out_floating_svi/tasks/main.yml Outdated Show resolved Hide resolved

[ignore] Addition of test statements for 'aci_l3out_floating_svi' to …

ca2d6c8

…incorporate all versions of apic

shrsr requested a review from akinross November 7, 2023 18:19

akinross requested changes Nov 8, 2023

View reviewed changes

tests/integration/targets/aci_l3out_floating_svi/tasks/main.yml Show resolved Hide resolved

akinross self-requested a review November 8, 2023 13:31

akinross previously approved these changes Nov 8, 2023

View reviewed changes

gmicol previously approved these changes Nov 8, 2023

View reviewed changes

lhercot previously approved these changes Nov 17, 2023

View reviewed changes

[ignore] Fix syntax using black on aci_l3out_floating_svi_path

870fb1c

lhercot dismissed stale reviews from gmicol, akinross, and themself via 870fb1c November 17, 2023 01:38

lhercot merged commit 4f26255 into CiscoDevNet:master Nov 17, 2023

gmicol mentioned this pull request Dec 21, 2023

L3out ansible module is incomplete #126

Closed

Addition of l3out Floating SVI module and its child modules #478

Addition of l3out Floating SVI module and its child modules #478

Uh oh!

Conversation

shrsr commented Sep 21, 2023

Uh oh!

codecov bot commented Sep 26, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

shrsr commented Oct 4, 2023

Uh oh!

Uh oh!

akinross left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

sajagana left a comment

Choose a reason for hiding this comment

Uh oh!

gmicol left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

akinross left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

akinross left a comment

Choose a reason for hiding this comment

Uh oh!

gmicol left a comment

Choose a reason for hiding this comment

Uh oh!

lhercot left a comment

Choose a reason for hiding this comment

Uh oh!

gmicol commented Dec 21, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

codecov bot commented Sep 26, 2023 •

edited

Loading